search

apache / iceberg-rust

Apache Iceberg
https://rust.iceberg.apache.org/
Apache License 2.0
616 stars 138 forks source link

Add hive metastore catalog support (part 2/2) #285

Closed marvinlanhenke closed 6 months ago

marvinlanhenke commented 6 months ago

Which issue does this PR close?

Closes #113

Rationale for this change

Add hive metastore support, to reach feature parity with other iceberg implementations.

What changes are included in this PR?

Implemented all of the table operations from the Catalog trait (except update_table)

Are these changes tested?

Yes. Unit and integration tests are included.

Are there any user-facing changes?

No.

marvinlanhenke commented 6 months ago

@marvinlanhenke This pr is amazing! I found some small problems to improve, but it looks great to me overall, thanks!

thanks for the extensive review - I'll get to the fixes today.

marvinlanhenke commented 6 months ago

@liurenjie1024 I fixed most of the issues / suggestions - thanks again.

Still unresolved / left to discuss:

liurenjie1024 commented 6 months ago

Let's wait to see if others have comments.

cc @Xuanwo @Fokko PTAL

liurenjie1024 commented 6 months ago

I'll merge this first to move on. We can refine it later if others have comments, thanks @marvinlanhenke