apache / iceberg-rust

Apache Iceberg

https://rust.iceberg.apache.org/

Apache License 2.0

616 stars 138 forks source link

feat: Glue Catalog - table operations (3/3) #314

Closed marvinlanhenke closed 5 months ago

marvinlanhenke commented 6 months ago

Which issue does this PR close?

Closes #249 (Task 3/3)

Rationale for this change

Add support for Glue Catalog, to reach feature parity with other implementations.

What changes are included in this PR?

add table operations
except fn update_table()

Are these changes tested?

Yes. Unit and integration tests are included.

marvinlanhenke commented 6 months ago

@liurenjie1024 PTAL

marvinlanhenke commented 5 months ago

Thanks for @marvinlanhenke for this great pr, it looks great! Sorry for late reply, I have been busy lately.

@liurenjie1024 No worries, and thanks for the review.

I'll most likely fix those remaining suggestions tomorrow.

marvinlanhenke commented 5 months ago

@liurenjie1024 I think I fixed all of your suggestions - thanks again for the review. For the 'missing table checks' - I'll file an Issue later, so we can track this and implement in separate PRs.

marvinlanhenke commented 5 months ago

For the 'missing table checks' - I'll file an Issue later, so we can track this and implement in separate PRs.

337

liurenjie1024 commented 5 months ago

Let's wait a moment to see if others have comments.

liurenjie1024 commented 5 months ago

cc @Fokko @Xuanwo @sdd PTAL

liurenjie1024 commented 5 months ago

Thanks @marvinlanhenke for this pr!