search

apache / iceberg-rust

Apache Iceberg
https://rust.iceberg.apache.org/
Apache License 2.0
616 stars 138 forks source link

Add `BoundPredicateVisitor` trait #320

Closed sdd closed 5 months ago

sdd commented 6 months ago

This trait is used for BoundPredicate visitors that evaluate the predicate, and associated tests. It has been broken out of the https://github.com/apache/iceberg-rust/pull/241 PR as that was getting too large.

sdd commented 5 months ago

I've added a test for visit_op, as well as some doc comments.

Also, based on our discussion in the comments, it seemed prudent to add the non_exhaustive marker to PredicateOperator? PTAL @liurenjie1024, @marvinlanhenke, @ZENOTME as I think this is pretty much ready now

liurenjie1024 commented 5 months ago

Close by #334