search

apache / iceberg-rust

Apache Iceberg
https://rust.iceberg.apache.org/
Apache License 2.0
474 stars 97 forks source link

Simplify expression when doing `{and,or}` operations #339

Closed Fokko closed 2 months ago

Fokko commented 2 months ago

This will make sure that we nicely reduce the expression in the inclusive projection visitor: https://github.com/apache/iceberg-rust/blob/de80a2436bb2fbbd5b4ec6bcafd0bd041b263595/crates/iceberg/src/expr/visitors/inclusive_projection.rs#L73

Everyone is invited to comment on my limited 🦀 knowledge

marvinlanhenke commented 2 months ago

Everyone is invited to comment on my limited 🦀 knowledge

I'm sorry I cannot comment on this - other than LGTM 😏 thanks @Fokko

sdd commented 2 months ago

Nice! 😎