Open ZENOTME opened 2 months ago
This PR is complete https://github.com/apache/iceberg-rust/issues/345.
The design of this is based on https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/SnapshotProducer.java.
I implement a SnapshotProduceAction which will accept a Vec<ManifestFile> and Summary to generate a new snapshot and apply the snapshot to the tx.
Vec<ManifestFile>
Summary
FastAppendAction will reuse SnapshotProduceAction and have its own interface to process the added data files.
SnapshotProduceAction
In the future, we can reuse SnapshotProduceAction to implement more append actions with different commit semantics as described in https://github.com/apache/iceberg-rust/issues/348.
Please let me know if this design has something that can be improved and other things missed.
cc @liurenjie1024 @Fokko @Xuanwo
Hi, I have tried to fix this PR. Some things may not be fixed well now:
This PR is complete https://github.com/apache/iceberg-rust/issues/345.
The design of this is based on https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/SnapshotProducer.java.
I implement a SnapshotProduceAction which will accept a
Vec<ManifestFile>
andSummary
to generate a new snapshot and apply the snapshot to the tx.FastAppendAction will reuse
SnapshotProduceAction
and have its own interface to process the added data files.In the future, we can reuse
SnapshotProduceAction
to implement more append actions with different commit semantics as described in https://github.com/apache/iceberg-rust/issues/348.Please let me know if this design has something that can be improved and other things missed.