search

apache / iceberg-rust

Apache Iceberg
https://rust.iceberg.apache.org/
Apache License 2.0
474 stars 97 forks source link

Implement all functions of BoundPredicateVisitor for ManifestFilterVisitor #350

Closed s-akhtar-baig closed 2 weeks ago

s-akhtar-baig commented 2 months ago

ManifestEvaluator was implemented in https://github.com/apache/iceberg-rust/pull/322 whereas some functions are set to todo.

s-akhtar-baig commented 2 months ago

@Fokko, can you please assign this to me? @sdd, would it be okay if I work on this?

sdd commented 2 months ago

Please do! That would be great 😁

liurenjie1024 commented 2 months ago

@s-akhtar-baig Assigned, thanks!

marvinlanhenke commented 2 months ago

@s-akhtar-baig are you still working on this? If you like I could try to help you out here?

s-akhtar-baig commented 2 months ago

Thanks @marvinlanhenke, but I have made good progress on the task and will be creating a pull request in the next few days.

s-akhtar-baig commented 1 month ago

https://github.com/apache/iceberg-rust/pull/367 should close this issue. Most tests from pyiceberg have been implemented but some that are remaining will be covered in a follow-up PR.