apache / iceberg-rust

Apache Iceberg
https://rust.iceberg.apache.org/
Apache License 2.0
474 stars 97 forks source link

Correct names in the ManifestList #354

Closed Fokko closed 2 weeks ago

Fokko commented 2 months ago

Looking at the manifest list, we see the following names:

  {
    "name" : "added_data_files_count",
    "type" : "int"
  }, {
    "name" : "existing_data_files_count",
    "type" : "int"
  }, {
    "name" : "deleted_data_files_count",
    "type" : "int"
  }

With the V2 spec the names have been changed:

image

This is just cosmetic, since the fields are looked up by ID, but would be nice to fix this to avoid any future confusion.

s-akhtar-baig commented 2 months ago

@Fokko, can you please assign this to me? Thanks!

liurenjie1024 commented 2 months ago

@Fokko, can you please assign this to me? Thanks!

Done, thanks!

gupteaj commented 1 month ago

PR : https://github.com/apache/iceberg-rust/pull/380

liurenjie1024 commented 2 weeks ago

Close by #380 Thanks @gupteaj