search

apache / iceberg-rust

Apache Iceberg
https://rust.iceberg.apache.org/
Apache License 2.0
474 stars 97 forks source link

Implement BoundPredicateVisitor trait for ManifestFilterVisitor #367

Closed s-akhtar-baig closed 2 weeks ago

s-akhtar-baig commented 1 month ago

GitHub issue: https://github.com/apache/iceberg-rust/issues/350

Description: ManifestEvaluator was defined in https://github.com/apache/iceberg-rust/pull/322. This PR implements all functions and adds most of the Python unit tests.

Testing: Added new unit tests.

s-akhtar-baig commented 1 month ago

@sdd, thank you for reviewing the changes and providing references! I have modified my code based on your suggestions. Please take a look and let me know if I miss anything.

s-akhtar-baig commented 3 weeks ago

@liurenjie1024 @marvinlanhenke @sdd, thank you for reviewing these changes and for your feedback! Greatly appreciated!

I have pushed the required changes. Please let me know if I missed anything, thanks!

sdd commented 3 weeks ago

Hi @liurenjie1024 - sorry to pester you but are you able to re-review this please? It's the last major piece of the puzzle on the read side.

liurenjie1024 commented 2 weeks ago

Hi @liurenjie1024 - sorry to pester you but are you able to re-review this please? It's the last major piece of the puzzle on the read side.

Hi, @sdd Sorry for delay. I'll review it today.

liurenjie1024 commented 2 weeks ago

cc @Fokko Do you want to take a review for this? I see you assigned yourself for review.