search

apache / iceberg-rust

Apache Iceberg
https://rust.iceberg.apache.org/
Apache License 2.0
474 stars 97 forks source link

Rename IO traits to `IcebergFileRead` or `IcebergRead`? #368

Open Xuanwo opened 1 month ago

Xuanwo commented 1 month ago 
          Maybe we could call this `IcebergFileRead` or `IcebergRead`? I suppose that's a bit redundant as it would be clear that it is from us by navigating to the `use` statement where it gets imported, but I'm just conscious that there are a lot of `Read` and `Write` traits dotted around and we could make it easier to see which one is ours at-a-glance where ever it is used in the future.

_Originally posted by @sdd in https://github.com/apache/iceberg-rust/pull/364#discussion_r1596342297_

Xuanwo commented 1 month ago

cc @liurenjie1024 @Fokko, what do you think about this?

liurenjie1024 commented 1 month ago

To be honest I'm netural to this, is there any reason why we need to do this?

Xuanwo commented 1 month ago

To be honest I'm netural to this, is there any reason why we need to do this?

I'm fine with this too. I'm going to let this issue open for more feedback.