search

apache / iceberg-rust

Apache Iceberg
https://rust.iceberg.apache.org/
Apache License 2.0
469 stars 95 forks source link

feat: support lower_bound&&upper_bound for parquet writer #383

Open ZENOTME opened 1 month ago

ZENOTME commented 1 month ago

This PR calculates the lower_bound&&upper_bound using the metadata returned by the parquet writer. The implementation refer: https://github.com/apache/iceberg-python/blob/b8023d294ac057abc15a19f05ee212517362d3d5/pyiceberg/io/pyarrow.py.

ZENOTME commented 1 month ago

cc @Fokko @liurenjie1024 @Xuanwo @sdd @marvinlanhenke

ZENOTME commented 1 month ago

This PR is blocked by #386 now.

ZENOTME commented 3 weeks ago

Thanks for your review! I have refined the code, please let me know if there is something that still can be improved. @sdd

liurenjie1024 commented 5 days ago

One minor hint: we should avoid using force push as much as possible so that reviewer could pick up review easily. We could use merge to resolve conflicts with main.

liurenjie1024 commented 2 days ago

Let's wait for a moment to see if others have comments.