search

apache / iceberg-rust

Apache Iceberg
https://rust.iceberg.apache.org/
Apache License 2.0
469 stars 95 forks source link

fix: complete miss attribute for map && list in avro schema #411

Open ZENOTME opened 1 week ago

ZENOTME commented 1 week ago

This PR is preparing for #131. We can merge it when Avro 0.17 released. See https://issues.apache.org/jira/browse/AVRO-4001 The main fix in avro 0.17 is the missing attribute in the map and list schema. I use the main branch to fix them first:

  1. serialize/deserialize the element id in list
  2. key-id, value-id in map
  3. array map, for now, we can detect using the LogicalType attr in avro array schema
liurenjie1024 commented 1 week ago

Thanks @ZENOTME for this pr, do you mind to postpone the review after avro-rs 0.17 release? I'm hesitating to add a dependency of an unreleased version.

ZENOTME commented 1 week ago

Thanks @ZENOTME for this pr, do you mind to postpone the review after avro-rs 0.17 release? I'm hesitating to add a dependency of an unreleased version.

LGTM. I'm just sending this PR in advance.🤣