search

apache / iceberg-rust

Apache Iceberg
https://rust.iceberg.apache.org/
Apache License 2.0
619 stars 139 forks source link

refactor: Implement ArrowAsyncFileWriter directly to remove tokio #427

Closed Xuanwo closed 3 months ago

Xuanwo commented 3 months ago

Close https://github.com/apache/iceberg-rust/issues/418

This PR uses the newly added ArrowAsyncFileWriter (aha, designed by me!) trait to remove the need of implementing tokio::AsyncWrite.

liurenjie1024 commented 3 months ago

Oops, seems we need to resolve conflicts first.

Xuanwo commented 3 months ago

Oops, seems we need to resolve conflicts first.

Addressed. PTAL.

liurenjie1024 commented 3 months ago

Thanks @Xuanwo for this pr, let's move!