search

apache / iceberg-rust

Apache Iceberg
https://rust.iceberg.apache.org/
Apache License 2.0
619 stars 139 forks source link

reuse docker container to save compute resources #428

Closed thexiay closed 2 months ago

thexiay commented 3 months ago

This PR is fixed for https://github.com/apache/iceberg-rust/issues/425

liurenjie1024 commented 2 months ago

cc @thexiay Sorry to ping you. This fix is blocking server other prs, and is relative important for 0.3 release. Do you have time working on it? I can help to pick up if you are busy.

thexiay commented 2 months ago

cc @thexiay Sorry to ping you. This fix is blocking server other prs, and is relative important for 0.3 release. Do you have time working on it? I can help to pick up if you are busy.

ok, i will finish it today.

liurenjie1024 commented 2 months ago

cc @thexiay Sorry to ping you. This fix is blocking server other prs, and is relative important for 0.3 release. Do you have time working on it? I can help to pick up if you are busy.

ok, i will finish it today.

Thanks!

thexiay commented 2 months ago

@liurenjie1024 cc

liurenjie1024 commented 2 months ago

Nit: there is a make check command to help you run check in local.

thexiay commented 2 months ago

cc @liurenjie1024 all comment is resolved