Closed Xuanwo closed 4 days ago
The problem is that the first update_config
may return things that may change behavior of rest client, for example headers, or relocated url, IIRC.
Got it. I have a better idea, let's discuss on the PR.
BTW should we use a strong-typed Config/Props instead of a Hashmap? Do we have discussions before?
BTW should we use a strong-typed Config/Props instead of a Hashmap? Do we have discussions before?
I like this idea. Please feel free to start a discussion about it. Actually, I'm not sure how many valid options are available in the props.
BTW should we use a strong-typed Config/Props instead of a Hashmap? Do we have discussions before?
It seems that there is no clear definition of all props.
Current reset catalog's init logic doesn't look good:
We need to:
self.config
)self.config.props
changed)self.config
)self.config.props
changed)self.config
)I suggest separating static and dynamic properties. Keep the configuration and HTTP client static, unchanged. Store dynamic properties separately and merge them only when sending a request. This approach could also help resolve issue #422.