search

apache / iceberg-rust

Apache Iceberg
https://rust.iceberg.apache.org/
Apache License 2.0
673 stars 159 forks source link

feat: SQL Catalog - Tables #610

Closed callum-ryan closed 1 month ago

callum-ryan commented 2 months ago

this is a WIP. Pulling tests in from @fqaiser94's original recommended test set as I go.

callum-ryan commented 1 month ago

Thanks @callum-ryan for this great pr! Generally LGTM, I've left some minor points to fix, others are great! One thing I want to ask is that do we have plan for tests against other databases such as postgres, mysql?

Thanks @liurenjie1024, I have fixed the points raised. I'm happy to take a look at integration tests for PostgreSQL and MySQL, it will take me some extra time as I am unfamiliar with the way these tests run for the repo. The REST catalog tests seem to be doing what I'd need to spin up some containers with the appropriate backends.