apache / iceberg-rust

Apache Iceberg
https://rust.iceberg.apache.org/
Apache License 2.0
675 stars 159 forks source link

Feat: Normalize TableMetadata #611

Closed c-thiel closed 2 months ago

c-thiel commented 2 months ago

This is a part of the TableMetadataBuilder (https://github.com/apache/iceberg-rust/pull/587).

Normalization of TableMetadata does:

In Java most of the validations can be found in the constructor: https://github.com/apache/iceberg/blob/ab2c6f889d07eeee51a1f58605be248e9330d91b/core/src/main/java/org/apache/iceberg/TableMetadata.java#L265

c-thiel commented 2 months ago

Thank you very much for working on this. I have a few style suggestions, but please feel free to disregard them if they don't suit you.

Thanks @Xuanwo, they all make sense! Addressed in Improve readability & comments