search

apache / iceberg-rust

Apache Iceberg
https://rust.iceberg.apache.org/
Apache License 2.0
673 stars 159 forks source link

refactor(python): Expose transform as a submodule for pyiceberg_core #628

Closed Xuanwo closed 2 months ago

Xuanwo commented 2 months ago

This PR will expose transform as a submodule for pyiceberg_core.

Also, this PR removes not useful hello_world function.

Xuanwo commented 2 months ago

Hi, @sungwy, would you like to take a review? I believe this way is more pythonic.

Xuanwo commented 2 months ago

There's an outstanding issue with pyo3 that prevents the functions defined within a module to be imported like below:

Oh, I see the problem. Let me take a look.

Xuanwo commented 2 months ago

Hi, @sungwy, I fixed this issue and add a test for it. Please take a look, thanks!

Xuanwo commented 2 months ago

Thank you @sungwy and @kevinjqliu for the quick review. We can implement more transforms in following PRs. And I will merge this one first 😘