fix: reorder record batch

apache / iceberg-rust

Apache Iceberg

https://rust.iceberg.apache.org/

Apache License 2.0

673 stars 159 forks source link

Closed chenzl25 closed 1 month ago

chenzl25 commented 2 months ago

Resolve https://github.com/apache/iceberg-rust/issues/627
As we know, FileScanTask has two fields project_field_ids and schema. I think the RecordBatch from the reader of this FileScanTask should always follow the schema specified in FileScanTask. However, Parquet projection mask might lose the original order which is unexpected. This PR tries to fix this issue by apply a reorder to the RecordBatch

sdd commented 2 months ago

I've already addressed this re-ordering in my open PR, https://github.com/apache/iceberg-rust/pull/602

chenzl25 commented 2 months ago

I've already addressed this re-ordering in my open PR, #602

Great news！Looking forward to your PR being merged.

liurenjie1024 commented 1 month ago

Should we close this? cc @chenzl25

chenzl25 commented 1 month ago

Should we close this? cc @chenzl25

Sure.