fix: page index evaluator min/max args inverted

apache / iceberg-rust

Apache Iceberg

https://rust.iceberg.apache.org/

Apache License 2.0

673 stars 159 forks source link

fix: page index evaluator min/max args inverted #648

Closed sdd closed 1 month ago

sdd commented 1 month ago

Fixes :https://github.com/apache/iceberg-rust/issues/647

I didn't catch all the places where I needed to change the order of the min / max args in an earlier refactor.

Added a few more tests to ensure this is covered properly. Also updated the other scan tests to ensure that they enable row selection as well so that this code path is covered in all of the scan tests.

sdd commented 1 month ago

@liurenjie1024 / @Xuanwo - would you be able to review this bug fix please? Without it, in some situations we return incorrect results when row selection is enabled. Thanks 😁