Closed a-agmon closed 1 month ago
Not familiar with rust, but do we have tests for such changes?
Not familiar with rust, but do we have tests for such changes?
Good point, this is mostly an access modifier change, and other parts are already covered by test, so generally LGTM. But it would be better to have some tests to cover the usage.
Thanks @manuzhang , I will also add an integration test to cover this.
Currently, it's quite complicated to query an existing iceberg table using DataFusion without a catalog. Enabling query using DataFusion with just a
Table
reference can make the API very flexible and usable because it enables us to query any Iceberg Table we want (with just the file_io and metadata location) regardless of its source or catalog.The proposed PR tries to achieve the following functionality, which enable users to create a queryable data fusion
TableProvider
from StaticTable