search

apache / iceberg-rust

Apache Iceberg
https://rust.iceberg.apache.org/
Apache License 2.0
673 stars 159 forks source link

feat: allow empty projection in table scan #677

Closed sundy-li closed 4 weeks ago

sundy-li commented 1 month ago

closes #676

Xuanwo commented 1 month ago

Failure in CI should be fixed by https://github.com/apache/iceberg-rust/pull/678

sdd commented 1 month ago

This looks good to me, thanks! I'm assuming that the reason why someone would want to perform a scan with an empty projection is to get a row count?

sundy-li commented 1 month ago

This looks good to me, thanks! I'm assuming that the reason why someone would want to perform a scan with an empty projection is to get a row count?

As I described in the issue, select count(0) from t would use empty scan (just need the read the metadata from parquet).

Xuanwo commented 4 weeks ago

Seems related opendal's new release, I will get it fixed.

sdd commented 4 weeks ago

@Xuanwo I've got a fix for that build issue here: https://github.com/apache/iceberg-rust/pull/680

Xuanwo commented 4 weeks ago

Thank you @sundy-li for this work, also thanks @liurenjie1024's review and @sdd for fixing CI, we are fine to merge now.