apache / iceberg-rust

Apache Iceberg
https://rust.iceberg.apache.org/
Apache License 2.0
673 stars 159 forks source link

ci: Fix CI for bindings python #678

Closed Xuanwo closed 1 month ago

Xuanwo commented 1 month ago

Hi, @kevinjqliu @sungwy, thank you for the review!

Github fix this from the runner side: https://github.com/actions/runner-images/pull/10794

I plan to add setup-python in every places we are going to use pip in the following PRs.

kevinjqliu commented 4 weeks ago

FYI, CI failing on main https://github.com/apache/iceberg-rust/commits/main/

Is it related to this PR?

error message,

error: use of deprecated method `opendal::Operator::is_exist`: rename to `exists` for consistence with `std::fs::exists`
   --> crates/iceberg/src/io/file_io.rs:100:15
    |
100 |         Ok(op.is_exist(relative_path).await?)
    |               ^^^^^^^^
    |
    = note: `-D deprecated` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(deprecated)]`

error: use of deprecated method `opendal::Operator::is_exist`: rename to `exists` for consistence with `std::fs::exists`
   --> crates/iceberg/src/io/file_io.rs:246:14
    |
246 |             .is_exist(&self.path[self.relative_path_pos..])
    |              ^^^^^^^^

error: use of deprecated method `opendal::Operator::is_exist`: rename to `exists` for consistence with `std::fs::exists`
   --> crates/iceberg/src/io/file_io.rs:328:14
    |
328 |             .is_exist(&self.path[self.relative_path_pos..])
    |              ^^^^^^^^
Xuanwo commented 4 weeks ago

FYI, CI failing on main

https://github.com/apache/iceberg-rust/commits/main/

Is it related to this PR?

error message,


error: use of deprecated method `opendal::Operator::is_exist`: rename to `exists` for consistence with `std::fs::exists`

   --> crates/iceberg/src/io/file_io.rs:100:15

    |

100 |         Ok(op.is_exist(relative_path).await?)

    |               ^^^^^^^^

    |

    = note: `-D deprecated` implied by `-D warnings`

    = help: to override `-D warnings` add `#[allow(deprecated)]`

error: use of deprecated method `opendal::Operator::is_exist`: rename to `exists` for consistence with `std::fs::exists`

   --> crates/iceberg/src/io/file_io.rs:246:14

    |

246 |             .is_exist(&self.path[self.relative_path_pos..])

    |              ^^^^^^^^

error: use of deprecated method `opendal::Operator::is_exist`: rename to `exists` for consistence with `std::fs::exists`

   --> crates/iceberg/src/io/file_io.rs:328:14

    |

328 |             .is_exist(&self.path[self.relative_path_pos..])

    |              ^^^^^^^^

Not related. opendal released a new version. I will fix it.