search

apache / iceberg

Apache Iceberg
https://iceberg.apache.org/
Apache License 2.0
6.49k stars 2.24k forks source link

OpenAPI: Remove credentials from LoadViewResult #11433

Closed nastra closed 3 weeks ago

nastra commented 3 weeks ago

The original idea why credentials were added to LoadViewResponse was to pass back the credentials to the table that the view is referencing. However, we actually want to wait with this until we have the use case fully defined on how this will work and want to remove the functionality for now, as otherwise we'd have to maintain reading/writing credentials in LoadViewResponse forever. We'll we sharing a separate proposal on how to realize this shortly on the mailing list.

RussellSpitzer commented 3 weeks ago

@danielcweeks @bryanck @jackye1995

Please review ASAP for the 1.7.0 release.

Like the other pr in core https://github.com/apache/iceberg/pull/11173 , this removes a detail in the spec that was added 2 weeks ago. We realize this may have been premature and want to remove it before adding it to the spec.

RussellSpitzer commented 3 weeks ago

Thanks @nastra , also @jbonofre and @singhpk234 for review