search

apache / iceberg

Apache Iceberg
https://iceberg.apache.org/
Apache License 2.0
6.51k stars 2.25k forks source link

API: Removes Explicit Parameterization of Schema Tests #11444

Closed RussellSpitzer closed 2 weeks ago

RussellSpitzer commented 3 weeks ago

A lot of our tests are currently very specific but are going to be reused for various other types as they get added. We also currently hard code in the versions we are testing. This makes it a little more difficult whenever we add a new format version to correctly update all of the corresponding tests.

I'm updating TestSchema to show what I think should be our general pattern for version specific testing where the versions tested are defined in a single location rather than each time per test.

For the "type" tests, rather than making a named test per type, we parameterize over the type itself so that new types (Geo and Variant) can be added without duplicating code.

RussellSpitzer commented 3 weeks ago

Test results look like image

RussellSpitzer commented 2 weeks ago

Thanks @aihuaxu , @Fokko and @nastra for reviews!