search

apache / iceberg

Apache Iceberg
https://iceberg.apache.org/
Apache License 2.0
6.51k stars 2.25k forks source link

Parquet: Use native getRowIndexOffset support instead of calculating it #11520

Closed wypoon closed 5 days ago

wypoon commented 2 weeks ago

@szehon-ho @flyrain can you please review? cc @huaxingao

wypoon commented 1 week ago

@Fokko thanks for reviewing! I'd actually updated the deprecation comments locally but failed to commit the change before I pushed.

wypoon commented 1 week ago

@huaxingao @Fokko I have updated the PR; please review again.

wypoon commented 1 week ago

@Fokko can you help merge this if you have no further feedback?

flyrain commented 6 days ago

Hi @Fokko, do you have any further feedback?

huaxingao commented 5 days ago

@Fokko @flyrain Should we merge this PR? I am waiting for it to be merged so I can clean up my temporary code

flyrain commented 5 days ago

I will merge it if there is no new comment by EOD.

flyrain commented 5 days ago

Thanks @wypoon for working on it. Thanks @huaxingao @Fokko @szehon-ho for the review.