search

apache / iceberg

Apache Iceberg
https://iceberg.apache.org/
Apache License 2.0
6.49k stars 2.24k forks source link

Kafka Connect: Add config to prefix the control consumer group #11599

Open hugofriant opened 1 day ago

hugofriant commented 1 day ago

I would like to control the name of the control consumer group to have more fine grained accesses when deploying the Iceberg Sink connector on my infrastructure.

This PR aims to replace the DEFAULT_CONTROL_GROUP_PREFIX by a configurable variable

jbonofre commented 14 hours ago

@bryanck @rdblue I reviewed this PR and worked with @hugofriant on nit changes. I think this PR is ready to be merged 😄 Can you please take a look as well ? Thanks !

jbonofre commented 13 hours ago

@RussellSpitzer I reviewed this PR and worked with @hugofriant on nit changes. I think this PR is ready to be merged 😄 Can you also please take a look (and merge) ? Thanks !

bryanck commented 13 hours ago

Thanks for the PR @hugofriant , I had just a few naming nits