search

apache / iceberg

Apache Iceberg
https://iceberg.apache.org/
Apache License 2.0
6.49k stars 2.24k forks source link

Revert "Core: Update TableMetadataParser to ensure all streams closed (#11220)" #11621

Closed hussein-awala closed 9 hours ago

hussein-awala commented 11 hours ago

This reverts commit 2b55fef7cc2a249d864ac26d85a4923313d96a59.

https://github.com/apache/iceberg/pull/11220 introduced a new bug instead of fixing the original issue, where it fixed the case where there is an exception in the GZIPOutputStream constructor, but if there is not, the stream will be closed when try-with-resources tries to close it and it will throw an exception.

The original issue will be fixed by https://github.com/apache/iceberg/pull/11609.

amogh-jahagirdar commented 9 hours ago

Thanks @hussein-awala , agree with just reverting this first.