Closed bitsondatadev closed 2 weeks ago
@bitsondatadev looks like https://iceberg.apache.org/docs/latest/spark-procedures/#expire_snapshots
is valid URL. Should we use _
underscore instead of hyphen -
for these links?
To keep compatibility with the old site, we should support both. The only time this becomes an issue is if you have a saved link (or Google in the short term) but using the -
will still take you to the page, just not the header.
For now use _
and if there becomes a real need we'll implement it.
Thanks. Sounds good. Also, looks like all procedure names have a _
separator. So it would be consistent with that convention.
Thanks for this @raghits, have you noticed any other header not using the underscore?
I haven't checked myself.
@bitsondatadev here are the references where the hyphen (expire-snapshots
) is used but those URLs valid and hence I didn't update it:
https://github.com/apache/iceberg/blob/main/docs/docs/spark-structured-streaming.md
https://github.com/apache/iceberg/blob/main/docs/docs/flink-writes.md
This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.
This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'
The current link fails for the current site: https://iceberg.apache.org/docs/latest/spark-procedures/#expire-snapshots
The reason my linkchecker missed this was that it still loads the page just not the link. So we'll need to do a pass at these in a later PR.