GridDhtTxFinishRequest redundant class members was removed:
GridDhtTxFinishRequest#partUpdateCounters() usage was removed in IGNITE-10078 [1]. Thus, this method seems to be useless.
Getter for GridDhtTxFinishRequest#pendingVers() was removed in [2], but actually it was unused since initial commit.
GridDhtTxFinishRequest#writeVersion() usage was removed before first Ignite release in [3] and as I see GridDistributedTxPrepareRequest#writeVersion() is used instead [4-6].
GridDhtTxFinishRequest#isolation() usages was removed before first Ignite release: see [7, 8].
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
[x] There is a single JIRA ticket related to the pull request.
[x] The web-link to the pull request is attached to the JIRA ticket.
[x] The JIRA ticket has the Patch Available state.
[x] The pull request body describes changes that have been made.
The description explains WHAT and WHY was made instead of HOW.
[x] The pull request title is treated as the final commit message.
The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
[x] A reviewer has been mentioned through the JIRA comments
(see the Maintainers list)
[x] The pull request has been checked by the Teamcity Bot and
the green visa attached to the JIRA ticket (see TC.Bot: Check PR)
Description
GridDhtTxFinishRequest redundant class members was removed:
GridDhtTxFinishRequest#partUpdateCounters()
usage was removed in IGNITE-10078 [1]. Thus, this method seems to be useless.Getter for
GridDhtTxFinishRequest#pendingVers()
was removed in [2], but actually it was unused since initial commit.GridDhtTxFinishRequest#writeVersion()
usage was removed before first Ignite release in [3] and as I seeGridDistributedTxPrepareRequest#writeVersion()
is used instead [4-6].GridDhtTxFinishRequest#isolation()
usages was removed before first Ignite release: see [7, 8].Links:
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:
The Contribution Checklist
IGNITE-XXXX Change summary
whereXXXX
- number of JIRA issue.green visa
attached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.