apache / ignite

Apache Ignite
https://ignite.apache.org/
Apache License 2.0
4.83k stars 1.9k forks source link

IGNITE-22920 Final cleanup of GridDhtTxFinishRequest #11477

Closed shishkovilja closed 2 months ago

shishkovilja commented 3 months ago

Description

GridDhtTxFinishRequest redundant class members was removed:

GridDhtTxFinishRequest#partUpdateCounters() usage was removed in IGNITE-10078 [1]. Thus, this method seems to be useless.

Getter for GridDhtTxFinishRequest#pendingVers() was removed in [2], but actually it was unused since initial commit.

GridDhtTxFinishRequest#writeVersion() usage was removed before first Ignite release in [3] and as I see GridDistributedTxPrepareRequest#writeVersion() is used instead [4-6].

GridDhtTxFinishRequest#isolation() usages was removed before first Ignite release: see [7, 8].

Links:

  1. https://github.com/apache/ignite/commit/e7a90a445f09b0783918a0b5cfbeddee7102c45e#diff-0b00deac783b25444a9201a862ba487bb1f83de7dd319edd2b02064b8efebbeaL1426 (IgniteTxHandler:1426 left)
  2. https://github.com/apache/ignite/commit/457a9ae4d3b0d6eef6e92a15f5ef79c15ccf1f95#diff-3ef6211e80513fc51e2185d3c1b59378aed8d18d2744e7a0dfa92018fba8d684L310 (GridDhtTxFinishRequest:310 left)
  3. https://github.com/apache/ignite/commit/0354a41b94e891273a06587c6cea95aaee15d995#diff-0b00deac783b25444a9201a862ba487bb1f83de7dd319edd2b02064b8efebbeaL735 (IgniteTxHandler:735 left)
  4. https://github.com/apache/ignite/commit/0354a41b94e891273a06587c6cea95aaee15d995#diff-0b00deac783b25444a9201a862ba487bb1f83de7dd319edd2b02064b8efebbeaR827 (IgniteTxHandler:827 right)
  5. https://github.com/apache/ignite/commit/0354a41b94e891273a06587c6cea95aaee15d995#diff-0b00deac783b25444a9201a862ba487bb1f83de7dd319edd2b02064b8efebbeaR910 (IgniteTxHandler:910 right)
  6. https://github.com/apache/ignite/commit/0354a41b94e891273a06587c6cea95aaee15d995#diff-0b00deac783b25444a9201a862ba487bb1f83de7dd319edd2b02064b8efebbeaR1029 (IgniteTxHandler:1029 right)
  7. https://github.com/apache/ignite/commit/0354a41b94e891273a06587c6cea95aaee15d995#diff-0b00deac783b25444a9201a862ba487bb1f83de7dd319edd2b02064b8efebbeaL1145 (IgniteTxHandler:1145 left)
  8. https://github.com/apache/ignite/commit/0354a41b94e891273a06587c6cea95aaee15d995#diff-0b00deac783b25444a9201a862ba487bb1f83de7dd319edd2b02064b8efebbeaL1292 (IgniteTxHandler:1292 left)

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

The Contribution Checklist

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
40.0% Duplication on New Code

See analysis details on SonarCloud