search

apache / incubator-annotator

Apache Annotator provides annotation enabling code for browsers, servers, and humans.
https://annotator.apache.org/
Apache License 2.0
218 stars 44 forks source link

Tweak types #136

Closed Treora closed 11 months ago

Treora commented 1 year ago

Based on experience in Web Annotation Discovery webextension. See here.

reckart commented 11 months ago

@Treora do you have any particular doubts about this PR that need to be clarified by other developers? Do you see any reason not to merge this PR?

Treora commented 11 months ago

Thanks for taking a look. It’s been a while.. I think these changes should be uncontroversial. Tests appear to pass. In case we do find any mistakes we can just as well fix them after merging. I’ll press the button already if you allow me the pleasure. ;)