apache / incubator-annotator

Apache Annotator provides annotation enabling code for browsers, servers, and humans.
https://annotator.apache.org/
Apache License 2.0
218 stars 44 forks source link

#146 - Update dependencies #147

Closed reckart closed 11 months ago

reckart commented 11 months ago
reckart commented 11 months ago

@tilgovi @BigBlueHat @Treora I have done pretty radical update of dependencies here. Looks like the build process is happy. Anybody care to have a look at these changes since I'm not really too familiar with the tooling used by Apache Annotator.

I still think switching to plain npm would be better these days (and drop lerna and yarn). Also I thing esbuild instead of webpack would be nice :) ... but that would be a different issue/PR.

tilgovi commented 11 months ago

Looks great. I will make a PR to drop Yarn for NPM, because I don't think there is any benefit to continuing to use Yarn (especially not without the advanced features).

Can you say anything about the non-dependency changes here? The ajv invocation and the lerna.json?

tilgovi commented 11 months ago

I'm guessing useWorkspaces is just gone these days.

I started looking at updating Lerna and trying out Nx a while back. I'll see where my branch got and try to see whether it's worth doing anything with these tools still.

Thanks again for looking at this.

reckart commented 11 months ago

Lerna said that useWorkspaces no longer exists.

And auto was no longer a valid value for schemaId in Ajv. I considered specifying a particular schema version, but since the parameter is optional and the build works without specifying a version, I left it without the schemaId.