branding image should be deleted after new image uploaded

apache / incubator-answer

A Q&A platform software for teams at any scales. Whether it's a community forum, help center, or knowledge management platform, you can always count on Apache Answer.

https://answer.apache.org

Apache License 2.0

13k stars 1.01k forks source link

branding image should be deleted after new image uploaded #589

Open cruvie opened 1 year ago

cruvie commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

deploy with docker-compose
upload brand image twice
check path /answer-data/uploads/branding
See two images include the previous one

Expected behavior the previous image should be deleted

Platform (please complete the following information):

Device: Desktop
OS: macOS
Browser edge
Version 1.2.0

kelvinkuo commented 1 year ago

Is this so important? Changing logo is a very low frequency operation. So disk wasting is not too much. Maybe there will be a feature like "recovering the last logo" some day and need keeping the last logo on disk.

My personal thoughts.

@cruvie

Octobug commented 8 months ago

This is relevant to apache/incubator-answer-plugins#257 , which provides a management UI for uploads.