search

apache / incubator-gluten

Gluten is a middle layer responsible for offloading JVM-based SQL engines' execution to native engines.
https://gluten.apache.org/
Apache License 2.0
1.14k stars 411 forks source link

[VL] Not support GMT+8 timezone #5169

Open weiting-chen opened 5 months ago

weiting-chen commented 5 months ago

Backend

VL (Velox)

Bug description

Velox report not support GMT+8. The reproduce SQL in below: create table ttzz stored as parquet as select '2020-01-01 08:00:00' as t; set spark.sql.session.timeZone=GMT+8; select * from ttzz where cast(t as timestamp) is not null;

Spark version

None

Spark configurations

No response

System information

No response

Relevant logs

No response

PHILO-HE commented 5 months ago

Looks a similar unsupported case like "+08:00". It's under investigation.

boneanxs commented 4 months ago

Looks a similar unsupported case like "+08:00". It's under investigation.

@PHILO-HE Hey, I think "+08:00" can be supported, can see this pr: https://github.com/facebookincubator/velox/pull/9403#pullrequestreview-1991204528

but yes, "GMT+n" is not supported

PHILO-HE commented 4 months ago

Looks a similar unsupported case like "+08:00". It's under investigation.

@PHILO-HE Hey, I think "+08:00" can be supported, can see this pr: facebookincubator/velox#9403 (review)

but yes, "GMT+n" is not supported

@boneanxs, I'll take a look. Thanks!

PHILO-HE commented 4 months ago

We have one PR in upstream velox: https://github.com/facebookincubator/velox/pull/9591.