apache / incubator-gluten

Gluten is a middle layer responsible for offloading JVM-based SQL engines' execution to native engines.
https://gluten.apache.org/
Apache License 2.0
1.03k stars 368 forks source link

[VL] Refine CMAKE_CXX_FLAGS setting logic #5769

Closed Yohahaha closed 2 weeks ago

Yohahaha commented 2 weeks ago

What changes were proposed in this pull request?

Modify CMAKE_CXX_FLAGS generation logic for each native module, and make it clearly to see all the CMAKE_CXX_FLAGS.

github-actions[bot] commented 2 weeks ago

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

FelixYBW commented 2 weeks ago

Is there impact to build process?

Yohahaha commented 2 weeks ago

Is there impact to build process?

no changes, just a little refactor.

Yohahaha commented 2 weeks ago

@marin-ma @PHILO-HE please help take a look, thank you!