search

apache / incubator-gluten

Gluten is a middle layer responsible for offloading JVM-based SQL engines' execution to native engines.
https://gluten.apache.org/
Apache License 2.0
1.13k stars 409 forks source link

[VL] Add CPP unit test for UDF #6195

Closed NEUpanning closed 1 month ago

NEUpanning commented 2 months ago

Description

The UDF examples only have TestMyUDF.cc for testing whether UDF is registered and VeloxUdfSuite.scala for integration test. In our practice, we need compile gluten java code for testing after changing the UDF cpp code, which takes a lot of time. Maybe we should add unit test like Velox functions test so we can save the time for doing scala test.

NEUpanning commented 2 months ago

@marin-ma How do you think? Thanks!

marin-ma commented 2 months ago

@NEUpanning +1 Thanks for the proposal. We have one simple executable here to test the UDF registration https://github.com/apache/incubator-gluten/blob/main/cpp/velox/udf/examples/TestMyUDF.cc Not sure if it would be helpful to create the UDF CPP test framework.

Would you like to help on implementing this?

NEUpanning commented 2 months ago

@marin-ma Thanks for your reply. I would like to implement this.