search

apache / incubator-gluten

Gluten is a middle layer responsible for offloading JVM-based SQL engines' execution to native engines.
https://gluten.apache.org/
Apache License 2.0
1.22k stars 437 forks source link

Use newer version of clang-format(clang-format-18) #6900

Closed xumingming closed 3 months ago

xumingming commented 3 months ago

Problem description

There are more recent clang-format-18:

root@test:~/Code/gluten# apt search clang-format
Sorting... Done
Full Text Search... Done
clang-format/noble 1:18.0-59~exp2 arm64
  Tool to format C/C++/Obj-C code

clang-format-14/noble 1:14.0.6-19build4 arm64
  Tool to format C/C++/Obj-C code

clang-format-15/noble,now 1:15.0.7-14build3 arm64 [installed]
  Tool to format C/C++/Obj-C code

clang-format-16/noble 1:16.0.6-23ubuntu4 arm64
  Tool to format C/C++/Obj-C code

clang-format-17/noble 1:17.0.6-9ubuntu1 arm64
  Tool to format C/C++/Obj-C code

clang-format-18/noble-updates,now 1:18.1.3-1ubuntu1 arm64 [installed]
  Tool to format C/C++/Obj-C code

libcode-tidyall-plugin-clangformat-perl/noble 0.0.2-2 all
  module to run clang-format using Code::TidyAll

System information

N/A

CMake log

No response

xumingming commented 3 months ago

Velox is using clang-format-18: https://github.com/facebookincubator/velox/blob/54b16e0416ada85dd2904b2d2bee7650a1d27b36/scripts/setup-check.sh#L21