search

apache / incubator-gluten

Gluten is a middle layer responsible for offloading JVM-based SQL engines' execution to native engines.
https://gluten.apache.org/
Apache License 2.0
1.22k stars 437 forks source link

[VL] Upgrade to g++-11 to support C++20 #7458

Open zhouyuan opened 1 month ago

zhouyuan commented 1 month ago

Description

As Velox is migrating to C++20 https://github.com/facebookincubator/velox/discussions/10692 The minimal requirement is g++-11. We should upgrade the toolchain: https://vault.centos.org/centos/7/sclo/Source/rh/

PHILO-HE commented 1 month ago

We have to move ahead since Velox recently upgraded folly that requires GCC >=10. I will create a pr to do this.

/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/deps-download/folly/folly/Portability.h:38:24: error: static assertion failed: __GNUC__ >= 10
   38 | static_assert(__GNUC__ >= 10, "__GNUC__ >= 10");
      |                        ^
ninja: build stopped: subcommand failed.
FelixYBW commented 1 month ago

CentOS 9 - default is GCC-11 but setups scripts installs and uses GCC-12 Ubuntu 22.04 - default is GCC-11 Ubuntu 24.04 - default is GCC-13 MacOS - Apple Clang-15

Looks CentOS7 and 8 may need to upgrade GCC firstly.

PHILO-HE commented 1 month ago

CentOS 9 - default is GCC-11 but setups scripts installs and uses GCC-12 Ubuntu 22.04 - default is GCC-11 Ubuntu 24.04 - default is GCC-13 MacOS - Apple Clang-15

Looks CentOS7 and 8 may need to upgrade GCC firstly.

@FelixYBW, yes, includes ubuntu 20.04.

PHILO-HE commented 3 weeks ago

Upgrading has been done in main branch, but still using c++17. Wait for Velox's change to use c++20.