apache / incubator-gluten

Gluten is a middle layer responsible for offloading JVM-based SQL engines' execution to native engines.
https://gluten.apache.org/
Apache License 2.0
1.22k stars 437 forks source link

[VL] Fix wrong lib suffix for google_cloud_cpp_storage #7933

Closed PHILO-HE closed 1 week ago

PHILO-HE commented 1 week ago

What changes were proposed in this pull request?

Currently, static google_cloud_cpp_storage lib is used in both static build and dynamic build. The lib suffix was wrongly set for CMake to find the lib.

How was this patch tested?

Local verification.

github-actions[bot] commented 1 week ago

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

PHILO-HE commented 1 week ago

@zhztheplayer, just verified, we should set ".a" as the suffix for GCS.