Closed baibaichen closed 1 week ago
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename commit message and pull request title in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
Run Gluten Clickhouse CI on x86
Run Gluten Clickhouse CI on x86
Run Gluten Clickhouse CI on x86
What changes were proposed in this pull request?
This PR fix 2 issues:
Issue 1
BuildQueryPipelineSettings
is created manually instead of callingBuildQueryPipelineSettings::fromContext();
so even https://github.com/ClickHouse/ClickHouse/pull/71890 disable'query_plan_merge_filters'
, UTs are still failed.To fix this issue, we need set correct default parameters in CHUtil.cpp
Issue 2
If we set
query_plan_merge_filters
to true, then https://github.com/ClickHouse/ClickHouse/pull/71539 will try to split the left most AND atom to a separate DAG and hence createFilterTransformer
for each And atom, which cause collecting metrics failed.I am not sure the benefits of setting it to true, let's keep it to false.
How was this patch tested?
Using Existed UTs