apache / incubator-gluten

Gluten is a middle layer responsible for offloading JVM-based SQL engines' execution to native engines.
https://gluten.apache.org/
Apache License 2.0
1.22k stars 437 forks source link

[CH] Fix issues due to https://github.com/ClickHouse/ClickHouse/pull/71539 #7952

Closed baibaichen closed 1 week ago

baibaichen commented 1 week ago

What changes were proposed in this pull request?

This PR fix 2 issues:

Issue 1

BuildQueryPipelineSettings is created manually instead of calling BuildQueryPipelineSettings::fromContext(); so even https://github.com/ClickHouse/ClickHouse/pull/71890 disable 'query_plan_merge_filters', UTs are still failed.

To fix this issue, we need set correct default parameters in CHUtil.cpp

Issue 2

If we set query_plan_merge_filters to true, then https://github.com/ClickHouse/ClickHouse/pull/71539 will try to split the left most AND atom to a separate DAG and hence create FilterTransformer for each And atom, which cause collecting metrics failed.

I am not sure the benefits of setting it to true, let's keep it to false.

How was this patch tested?

Using Existed UTs

github-actions[bot] commented 1 week ago

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

github-actions[bot] commented 1 week ago

Run Gluten Clickhouse CI on x86

github-actions[bot] commented 1 week ago

Run Gluten Clickhouse CI on x86

github-actions[bot] commented 1 week ago

Run Gluten Clickhouse CI on x86