apache / incubator-gluten

Gluten is a middle layer responsible for offloading JVM-based SQL engines' execution to native engines.
https://gluten.apache.org/
Apache License 2.0
1.22k stars 437 forks source link

[VL][1.2] Port #6573 #7025 #7132 #7973

Closed weiting-chen closed 1 day ago

weiting-chen commented 3 days ago

What changes were proposed in this pull request?

Port #7025 and #7132 for collectMetrics and skip command execution bugfix

How was this patch tested?

local

github-actions[bot] commented 3 days ago

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

github-actions[bot] commented 3 days ago

Run Gluten Clickhouse CI on x86

zhouyuan commented 3 days ago

@weiting-chen it seems there are some other commits required:

/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/velox/exec/RowContainer.h: In instantiation of 'static void facebook::velox::exec::RowContainer::extractValuesWithNulls(const char* const*, folly::Range<const int*>, int32_t, int32_t, int32_t, uint8_t, int32_t, facebook::velox::FlatVector<T>*) [with bool useRowNumbers = false; T = facebook::velox::StringView; int32_t = int; uint8_t = unsigned char]':
/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/velox/exec/RowContainer.h:854:47:   required from 'static void facebook::velox::exec::RowContainer::extractColumnTypedInternal(const char* const*, folly::Range<const int*>, int32_t, facebook::velox::exec::RowColumn, int32_t, const VectorPtr&) [with bool useRowNumbers = false; facebook::velox::TypeKind Kind = facebook::velox::TypeKind::VARCHAR; int32_t = int; facebook::velox::VectorPtr = std::shared_ptr<facebook::velox::BaseVector>]'
/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/velox/exec/RowContainer.h:823:46:   required from 'static void facebook::velox::exec::RowContainer::extractColumnTyped(const char* const*, folly::Range<const int*>, int32_t, facebook::velox::exec::RowColumn, int32_t, const VectorPtr&) [with facebook::velox::TypeKind Kind = facebook::velox::TypeKind::VARCHAR; int32_t = int; facebook::velox::VectorPtr = std::shared_ptr<facebook::velox::BaseVector>]'
/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/velox/exec/RowContainer.h:1424:3:   required from here
/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/velox/exec/RowContainer.h:932:10: warning: variable 'values' set but not used [-Wunused-but-set-variable]
  932 |     auto values = valuesBuffer->asMutableRange<T>();
      |          ^~~~~~
[ 60%] Building CXX object velox/CMakeFiles/velox.dir/compute/iceberg/IcebergPlanConverter.cc.o
/__w/incubator-gluten/incubator-gluten/cpp/velox/compute/WholeStageResultIterator.cc: In member function 'void gluten::WholeStageResultIterator::collectMetrics()':
/__w/incubator-gluten/incubator-gluten/cpp/velox/compute/WholeStageResultIterator.cc:321:28: error: 'kShowTaskMetricsWhenFinished' was not declared in this scope
  321 |       veloxCfg_->get<bool>(kShowTaskMetricsWhenFinished, kShowTaskMetricsWhenFinishedDefault)) {
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/incubator-gluten/incubator-gluten/cpp/velox/compute/WholeStageResultIterator.cc:321:58: error: 'kShowTaskMetricsWhenFinishedDefault' was not declared in this scope
  321 |       veloxCfg_->get<bool>(kShowTaskMetricsWhenFinished, kShowTaskMetricsWhenFinishedDefault)) {
      |                                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
github-actions[bot] commented 2 days ago

Run Gluten Clickhouse CI on x86

weiting-chen commented 2 days ago

Missing #6573