apache / incubator-graphar

An open source, standard data file format for graph data storage and retrieval.
https://graphar.apache.org/
Apache License 2.0
195 stars 40 forks source link

[WIP][Spark] Replace Spark Info implementation with JAVA package #390

Closed Thespica closed 3 months ago

Thespica commented 4 months ago

Proposed changes

This PR is still working in progress, and need some discussion about implementation.

Besides, should make scala library align, with another PR(this PR does not include this work).

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

Related issue #276 Related discussion #379

SemyonSinchenko commented 3 months ago

It is a very complex change... @Thespica @acezen What do you think about creating another branch, like spark-java-refactroing, and making pull requests to it step by step? And merge to master only a finalized working version? Like some top-level refactoring, than replacing scala, than pyspark refactoring, documentation updates, etc.

acezen commented 3 months ago

It is a very complex change... @Thespica @acezen What do you think about creating another branch, like spark-java-refactroing, and making pull requests to it step by step? And merge to master only a finalized working version? Like some top-level refactoring, than replacing scala, than pyspark refactoring, documentation updates, etc.

This is a very good suggestion. Hi, @Thespica, I have created a spark-java-refactoring branch for the Info refactoring for JAVA and Spark. Can you reopen a pull request merge to spark-java-refactoring and we can implement the feature step by step like Sem suggest.