[Feat][C++] Support `Date` and `Timestamp` data type

apache / incubator-graphar

An open source, standard data file format for graph data storage and retrieval.

https://graphar.apache.org/

Apache License 2.0

195 stars 40 forks source link

[Feat][C++] Support `Date` and `Timestamp` data type #398

Closed acezen closed 3 months ago

acezen commented 3 months ago

Proposed changes

This change add feature that support Date and Timestamp data type in C++ library.

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

close #398 close #399

acezen commented 3 months ago

hi, @lixueclaire, can you help review this PR. This feature would not affect other data type and I would like to merge the implementation first and refactor the testing data of ldbc dataset(use the full ldbc dataset as testing), and add unit tests in another pull request.

acezen commented 3 months ago

Thank you for incorporating these two new data types, which significantly enhance GraphAr's versatility. It would be highly beneficial to include some illustrative examples and ensure that the documentation is updated accordingly to reflect these additions.

Thanks, I will open a new issue to include document and unit tests