apache / incubator-graphar

An open source, standard data file format for graph data storage and retrieval.
https://graphar.apache.org/
Apache License 2.0
195 stars 40 forks source link

[Feat][C++] Remove the custom namespace setting feature #414

Closed acezen closed 3 months ago

acezen commented 3 months ago

Is your feature request related to a problem? Please describe. Currently GraphAr C++ provides support user to set custom namespace to avoid name conflict. But since the namespace graphar is not a widely-used names, I suggest we can remove the feature.

Allowing users to set a custom namespace for a C++ library during the CMake configuration step is not considered a best practice in the C++ community.Here are several reasons why this approach is generally discouraged:

We should make the design right in the GraphAr's beginning

Describe the solution you'd like Remove the custom namespace setting feature.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

acezen commented 3 months ago

/cc @lixueclaire @Thespica