[Infra][Java] Repackaging Java library under the Apache namespace

apache / incubator-graphar

An open source, standard data file format for graph data storage and retrieval.

https://graphar.apache.org/

Apache License 2.0

217 stars 46 forks source link

[Infra][Java] Repackaging Java library under the Apache namespace #429

Closed acezen closed 6 months ago

acezen commented 6 months ago

Proposed changes

packaging from com.alibaba to org.apache
update the code directory structure from com/alibaba/graphar to org/apache/graphar
update related document

related to issue #427

acezen commented 6 months ago

@lixueclaire @Thespica This pull request may needs your review.

Thespica commented 6 months ago

Try to replace Java_com_alibaba_graphar_arrow_ArrowTable_1Static_1cxx_10x58c7409_nativeFromArrowArrayAndArrowSchema by Java_org_apache_graphar_arrow_ArrowTable_1Static_1cxx_10x58c7409_nativeFromArrowArrayAndArrowSchema in ffi code, the file name also needs to be change from jni_com_alibaba_graphar_arrow_ArrowTable_Static.cc to jni_org_apache_graphar_arrow_ArrowTable_Static.cc.

and replace jni_com_alibaba_graphar_arrow_ArrowTable_Static_cxx_0x58c7409.cc by jni_org_apache_graphar_arrow_ArrowTable_Static_cxx_0x58c7409.cc in cmake file.

acezen commented 6 months ago

Try to replace Java_com_alibaba_graphar_arrow_ArrowTable_1Static_1cxx_10x58c7409_nativeFromArrowArrayAndArrowSchema by Java_org_apache_graphar_arrow_ArrowTable_1Static_1cxx_10x58c7409_nativeFromArrowArrayAndArrowSchema in ffi code, the file name also needs to be change from jni_com_alibaba_graphar_arrow_ArrowTable_Static.cc to jni_org_apache_graphar_arrow_ArrowTable_Static.cc.

and replace jni_com_alibaba_graphar_arrow_ArrowTable_Static_cxx_0x58c7409.cc by jni_org_apache_graphar_arrow_ArrowTable_Static_cxx_0x58c7409.cc in cmake file.

Fixed, thanks for the review

acezen commented 6 months ago

Try to replace Java_com_alibaba_graphar_arrow_ArrowTable_1Static_1cxx_10x58c7409_nativeFromArrowArrayAndArrowSchema by Java_org_apache_graphar_arrow_ArrowTable_1Static_1cxx_10x58c7409_nativeFromArrowArrayAndArrowSchema in ffi code, the file name also needs to be change from jni_com_alibaba_graphar_arrow_ArrowTable_Static.cc to jni_org_apache_graphar_arrow_ArrowTable_Static.cc.

and replace jni_com_alibaba_graphar_arrow_ArrowTable_Static_cxx_0x58c7409.cc by jni_org_apache_graphar_arrow_ArrowTable_Static_cxx_0x58c7409.cc in cmake file.

The CI is passed. Please review again, thanks~