apache / incubator-graphar

An open source, standard data file format for graph data storage and retrieval.
https://graphar.apache.org/
Apache License 2.0
195 stars 40 forks source link

[Infra] Remove the third party action from CI #439

Closed acezen closed 2 months ago

acezen commented 2 months ago

Proposed changes

Apache project only allows to use github or apache's actions, try to replace the third-party action in CI.

SemyonSinchenko commented 2 months ago

@acezen, do you need help here with all this python stuff?

acezen commented 2 months ago

@acezen, do you need help here with all this python stuff?

yeah, Apache only allows project to use github/apache's actions in CI, can you help me how to replace the poetry related action in CI?

SemyonSinchenko commented 2 months ago

Of course. I will do it in the evening.

acezen commented 2 months ago

Of course. I will do it in the evening.

that's great! thanks Sem.

SemyonSinchenko commented 2 months ago

@acezen This way is working for me:

    - name: Install Poetry
      run: |
          yes | sudo python3 -m pip install poetry --quiet
          cd pyspark
          poetry env use python3

I tried it in my fork and it works

I see that you already made a lot of changes, so we can merge your current work and I will fix broken pipelines, or you can just copy-paste the way how I install poetry and it should work.

acezen commented 2 months ago

@acezen This way is working for me:

    - name: Install Poetry
      run: |
          yes | sudo python3 -m pip install poetry --quiet
          cd pyspark
          poetry env use python3

I tried it in my fork and it works

I see that you already made a lot of changes, so we can merge your current work and I will fix broken pipelines, or you can just copy-paste the way how I install poetry and it should work.

Thanks Sem, I will try to copy-paste to check the CI.

acezen commented 2 months ago

Hi, @SemyonSinchenko, it works! Can you take a review for the changes?

SemyonSinchenko commented 2 months ago

I think we still need to switch to latest Ubuntu, because 20.04 will stop getting security updates in the middle of 2024. I would suggest latest or 22.04.

acezen commented 2 months ago

for

It seems that the CI still run a ubuntu-20.04, we can merge this change first, and change to ubuntu-latest in another PR.