fix(license): fix LICENSE and NOTICE file according to ASF policy

apache / incubator-graphar

An open source, standard data file format for graph data storage and retrieval.

https://graphar.apache.org/

Apache License 2.0

192 stars 40 forks source link

fix(license): fix LICENSE and NOTICE file according to ASF policy #480

Closed acezen closed 1 month ago

acezen commented 1 month ago

Reason for this PR

as issue #479 describes

What changes are included in this PR?

for 3rd-party dependencies of graphar:

put licence information to LICENSE
put notice information to NOTICE

Are these changes tested?

Are there any user-facing changes?

acezen commented 1 month ago

Hi, @CalvinKirs @carp84, could you help review this PR?

CalvinKirs commented 1 month ago

Overall, this looks great! I noticed that we also kept the corresponding license header, which is excellent. I haven't checked if the referenced code has been modified on top of it, but if so, we can also add the corresponding AL2 header. FYI https://issues.apache.org/jira/browse/LEGAL-626

acezen commented 1 month ago

Overall, this looks great! I noticed that we also kept the corresponding license header, which is excellent. I haven't checked if the referenced code has been modified on top of it, but if so, we can also add the corresponding AL2 header. FYI https://issues.apache.org/jira/browse/LEGAL-626

Thanks for the reminder, some of them modified on top of the origin code. I would check and submit another PR to add the corresponding AL2 header.