search

apache / incubator-graphar

An open source, standard data file format for graph data storage and retrieval.
https://graphar.apache.org/
Apache License 2.0
192 stars 40 forks source link

chore: Add CHANGELOG.md #513

Closed acezen closed 2 weeks ago

acezen commented 3 weeks ago

Reason for this PR

Add CHANGELOG.md to project to to document all changes made to the project.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

SemyonSinchenko commented 3 weeks ago

Are you sure that we need to do it manually? Because google's release-please action can automate it. And this action is distributed under Apache 2.0

acezen commented 3 weeks ago

Are you sure that we need to do it manually? Because google's release-please action can automate it. And this action is distributed under Apache 2.0

The action seems great, I think we can automate it in our future releases.

SemyonSinchenko commented 3 weeks ago

The action seems great, I think we can automate it in our future releases.

I mean should we check the format of generated CHANGELOG.md by this action and try to align the current changes to the same format?

acezen commented 2 weeks ago

The action seems great, I think we can automate it in our future releases.

I mean should we check the format of generated CHANGELOG.md by this action and try to align the current changes to the same format?

the release-please application seems need to use the github_token but apache only provide tokens for specified application, see doc. It seems that we have to update the CHANGELOG.md manually.

SemyonSinchenko commented 2 weeks ago

I see. Thanks for the explanation @acezen LGTM, approved