apache / incubator-graphar

An open source, standard data file format for graph data storage and retrieval.
https://graphar.apache.org/
Apache License 2.0
192 stars 40 forks source link

feat(format): Implement the protocol definition of GraphAr format #521

Closed acezen closed 2 weeks ago

acezen commented 2 weeks ago

Reason for this PR

After implementation and including buf to graphar format definition, it's time to merge the format develop branch in to main.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

No

SemyonSinchenko commented 2 weeks ago

Why diff is so big? May you, please, make a force-push from main to the branch?

acezen commented 2 weeks ago

Why diff is so big? May you, please, make a force-push from main to the branch?

Done the rebase to main.

SemyonSinchenko commented 2 weeks ago

By the way, based on implemented GH action I can assume that we are not storing generated code in git, right? Did you see my email in a list about it? For me the question is not so clear. @acezen

acezen commented 2 weeks ago

By the way, based on implemented GH action I can assume that we are not storing generated code in git, right? Did you see my email in a list about it? For me the question is not so clear. @acezen

Yes, I see the disscussion. Currently we do not storing generated code. But if some libraries implementation prefer to storing generated code, it can be added in the future.