search

apache / incubator-graphar

An open source, standard data file format for graph data storage and retrieval.
https://graphar.apache.org/
Apache License 2.0
217 stars 46 forks source link

feat(ci): avoid running CI if pull request is still working in progress #602

Closed acezen closed 3 weeks ago

acezen commented 1 month ago

Describe the enhancement requested

To save the quota of CI resource, I suggest to avoid running CI when PR is still working in progress

we can refer to arrow's configuration

Component(s)

Continuous Integration

SemyonSinchenko commented 1 month ago

Another option is to run CI in the user's git instead of org git. Like it is done in Apache Spark when actions are running in PR author's fork instead the apache-repo: https://github.com/apache/spark/blob/master/.github/workflows/notify_test_workflow.yml#L38-L168

Thespica commented 1 month ago

for reference: not only check wip field in PR, but also check PR status by if: github.event.pull_request.draft == false.

from discussion here: https://github.com/orgs/community/discussions/25722

Thespica commented 1 month ago

BTW, @acezen

Could you refine maven log with -q option like what GraphScope do with this feat together?

SemyonSinchenko commented 1 month ago

Could you refine maven log with -q option like what GraphScope do with this feat together?

I do not like -q. We already made Maven logs much more readable by --no-transfer-progress but -q means that there were zero logs. Do we actually need it?

Thespica commented 1 month ago

Could you refine maven log with -q option like what GraphScope do with this feat together?

I do not like -q. We already made Maven logs much more readable by --no-transfer-progress but -q means that there were zero logs. Do we actually need it?

Thanks Sem, I ignored that we have already add the --no-transfer-progress option. Current situation is enough.

yecol commented 1 month ago

Github PR draft is designed for this.

Just open this as admin.

Screenshot 2024-08-22 at 10 56 13 AM
acezen commented 1 month ago

Github PR draft is designed for this.

Just open this as admin.

Screenshot 2024-08-22 at 10 56 13 AM

This looks perfect for this feat, I'll try to ask infra team to open Try draft pull request for GraphAr.

acezen commented 1 month ago

Github PR draft is designed for this. Just open this as admin.

Screenshot 2024-08-22 at 10 56 13 AM

This looks perfect for this feat, I'll try to ask infra team to open Try draft pull request for GraphAr.

It seems that draft pull request still trigger the CI, like https://github.com/apache/incubator-graphar/pull/606, I suggest that we can add check as @Thespica said.