search

apache / incubator-graphar

An open source, standard data file format for graph data storage and retrieval.
https://graphar.apache.org/
Apache License 2.0
225 stars 46 forks source link

feat!(format):change the naming of vertex/edge unique identify type from `label` to `type` #605

Closed Elssky closed 2 months ago

Elssky commented 2 months ago

Reason for this PR

https://github.com/apache/incubator-graphar/issues/604

What changes are included in this PR?

Change the naming of vertex/edge type from label to type

Are these changes tested?

yes, and changed testing https://github.com/apache/incubator-graphar-testing/pull/23

Are there any user-facing changes?

yes

BREAKING CHANGE:

acezen commented 2 months ago

hi, @Elssky, you should update the testing submodule to the latest commit

Elssky commented 2 months ago

hi, @Elssky, you should update the testing submodule to the latest commit yes

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 25 lines in your changes missing coverage. Please review.

Project coverage is 74.28%. Comparing base (359b829) to head (ecb1d4b). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ala/org/apache/graphar/example/GraphAr2Neo4j.scala 0.00% 11 Missing :warning:
...la/org/apache/graphar/example/GraphAr2Nebula.scala 0.00% 4 Missing :warning:
...la/org/apache/graphar/graph/GraphTransformer.scala 55.55% 2 Missing and 2 partials :warning:
...n/scala/org/apache/graphar/graph/GraphWriter.scala 85.71% 1 Missing and 2 partials :warning:
...r/src/main/scala/org/apache/graphar/EdgeInfo.scala 87.50% 0 Missing and 1 partial :warning:
.../src/main/scala/org/apache/graphar/GraphInfo.scala 66.66% 1 Missing :warning:
...src/main/scala/org/apache/graphar/VertexInfo.scala 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #605 +/- ## ============================================= - Coverage 95.11% 74.28% -20.84% - Complexity 0 226 +226 ============================================= Files 8 29 +21 Lines 737 2749 +2012 Branches 0 179 +179 ============================================= + Hits 701 2042 +1341 - Misses 36 551 +515 - Partials 0 156 +156 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.